Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed KWMessagePattern not matching class arguments. #517

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed KWMessagePattern not matching class arguments. #517

wants to merge 2 commits into from

Conversation

cristiankocza-sv
Copy link

The test below fails with the current code, due to KWMessagePattern encoding Class as NSData and evaluating it with equalsTo:.

it(@"Recognizes params with classes",^{
    NSMutableArray *array = [NSMutableArray array];
    [[[array should] receive] isKindOfClass:[NSArray class]];
    [array isKindOfClass:[NSArray class]];
});

The fix adds an extra KWObjCTypeIsClass() check.

I've also removed two -fno-objc-arc declarations from the Kiwi-OSX target, as the files are currently written for ARC and were causing on OSX unit tests.

@cristiankocza-sv
Copy link
Author

I found and fixed another issue, KWFormatter had some problems when in tried to format class objects that conformed to NSFastEnumeration, I added another commit with a fix for that.

@cristiankocza-sv cristiankocza-sv mentioned this pull request May 11, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cristiankocza-sv